Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officially support TypeScript 5 #269

Open
ejizba opened this issue Jun 7, 2024 · 0 comments · May be fixed by #303
Open

Officially support TypeScript 5 #269

ejizba opened this issue Jun 7, 2024 · 0 comments · May be fixed by #303

Comments

@ejizba
Copy link
Contributor

ejizba commented Jun 7, 2024

TypeScript v5 was released in March 2023. It's possible customers already got our package working with TS v5, but we need to investigate and officially add support.

Ideally we can support TypeScript v4 and v5 at the same time, but if not we should switch to TS v5 when we do the next major version of the @azure/functions package.

We have unit tests to cover TypeScript versions, which would need some updating:

  • Add TS v5 in package.json similar to how we have "typescript4": "typescript5": "npm:typescript@~5.0.0"
    • NOTE: There's a difference between the TS version used to build our code (the default) and these ones which are only used for testing. The test versions should be on minimum supported major versions for ideal validation, which is why they use "~" instead of "^"
  • Add '5' to the array of versions in the test here
  • Add several default functions to this file. You can compare to the v3.x branch to see what it should look like. Apparently we removed this temporarily for the new model and never added it back
@ejizba ejizba added the feature label Jun 7, 2024
@ejizba ejizba added this to the Backlog Candidates milestone Jun 21, 2024
@ejizba ejizba added the P1 label Jun 21, 2024
@ejizba ejizba self-assigned this Jul 22, 2024
@fseitun fseitun linked a pull request Oct 8, 2024 that will close this issue
@ejizba ejizba removed their assignment Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant