Merge pull request #200 from JoeyBarnes/main

Fixed a typo in Dynamic alert configuration
Azure · Apr 23, 2024 · 0ad5e1c · 0ad5e1c
2 parents db1ba0e + 2a9be41
commit 0ad5e1c
Show file tree

Hide file tree

Showing 9 changed files with 21 additions and 21 deletions.
diff --git a/services/ContainerInstance/containerGroups/alerts.yaml b/services/ContainerInstance/containerGroups/alerts.yaml
@@ -22,7 +22,7 @@
       - '*'
     failingPeriods:
       numberOfEvaluationPeriods: 4
-      minFailingPeroidsToAlert: minFailingPeroidsToAlert
+      minFailingPeriodsToAlert: 4
     alertSensitivity: Low
 - name: MemoryUsage
   description: Total memory usage in byte.
@@ -48,7 +48,7 @@
       - '*'
     failingPeriods:
       numberOfEvaluationPeriods: 4
-      minFailingPeroidsToAlert: minFailingPeroidsToAlert
+      minFailingPeriodsToAlert: 4
     alertSensitivity: Low
 - name: NetworkBytesReceivedPerSecond
   description: The network bytes received per second.
@@ -69,7 +69,7 @@
     criterionType: DynamicThresholdCriterion
     failingPeriods:
       numberOfEvaluationPeriods: 4
-      minFailingPeroidsToAlert: minFailingPeroidsToAlert
+      minFailingPeriodsToAlert: 4
     alertSensitivity: Low
 - name: NetworkBytesTransmittedPerSecond
   description: The network bytes transmitted per second.
@@ -90,5 +90,5 @@
     criterionType: DynamicThresholdCriterion
     failingPeriods:
       numberOfEvaluationPeriods: 4
-      minFailingPeroidsToAlert: minFailingPeroidsToAlert
+      minFailingPeriodsToAlert: 4
     alertSensitivity: Low
diff --git a/services/Logic/workflows/alerts.yaml b/services/Logic/workflows/alerts.yaml
@@ -173,7 +173,7 @@
     criterionType: DynamicThresholdCriterion
     failingPeriods:
       numberOfEvaluationPeriods: 4
-      minFailingPeroidsToAlert: minFailingPeroidsToAlert
+      minFailingPeriodsToAlert: 4
     alertSensitivity: Low
   references:
   - name: Monitor workflow run status, review trigger and workflow run history, and
@@ -200,7 +200,7 @@
     criterionType: DynamicThresholdCriterion
     failingPeriods:
       numberOfEvaluationPeriods: 4
-      minFailingPeroidsToAlert: minFailingPeroidsToAlert
+      minFailingPeriodsToAlert: 4
     alertSensitivity: Low
   references:
   - name: Monitor workflow run status, review trigger and workflow run history, and
@@ -401,5 +401,5 @@
     criterionType: DynamicThresholdCriterion
     failingPeriods:
       numberOfEvaluationPeriods: 4
-      minFailingPeroidsToAlert: minFailingPeroidsToAlert
+      minFailingPeriodsToAlert: 4
     alertSensitivity: Medium
diff --git a/services/Network/dnszones/alerts.yaml b/services/Network/dnszones/alerts.yaml
@@ -35,5 +35,5 @@
     criterionType: DynamicThresholdCriterion
     failingPeriods:
       numberOfEvaluationPeriods: 4
-      minFailingPeroidsToAlert: minFailingPeroidsToAlert
+      minFailingPeriodsToAlert: 4
     alertSensitivity: Low
diff --git a/services/Network/virtualNetworkGateways/alerts.yaml b/services/Network/virtualNetworkGateways/alerts.yaml
@@ -353,7 +353,7 @@
     criterionType: DynamicThresholdCriterion
     failingPeriods:
       numberOfEvaluationPeriods: 4
-      minFailingPeroidsToAlert: minFailingPeroidsToAlert
+      minFailingPeriodsToAlert: 4
     alertSensitivity: Medium
 - name: TunnelIngressPacketDropCount
   description: Count of incoming packets dropped by tunnel
@@ -374,7 +374,7 @@
     criterionType: DynamicThresholdCriterion
     failingPeriods:
       numberOfEvaluationPeriods: 4
-      minFailingPeroidsToAlert: minFailingPeroidsToAlert
+      minFailingPeriodsToAlert: 4
     alertSensitivity: Medium
 - name: TunnelIngressBytes
   description: Incoming bytes of a tunnel
@@ -413,7 +413,7 @@
     criterionType: DynamicThresholdCriterion
     failingPeriods:
       numberOfEvaluationPeriods: 4
-      minFailingPeroidsToAlert: minFailingPeroidsToAlert
+      minFailingPeriodsToAlert: 4
     alertSensitivity: Medium
 - name: TunnelIngressPacketDropTSMismatch
   description: Incoming packet drop count from traffic selector mismatch of a tunnel
@@ -434,5 +434,5 @@
     criterionType: DynamicThresholdCriterion
     failingPeriods:
       numberOfEvaluationPeriods: 4
-      minFailingPeroidsToAlert: minFailingPeroidsToAlert
+      minFailingPeriodsToAlert: 4
     alertSensitivity: Medium
diff --git a/services/OperationalInsights/workspaces/alerts.yaml b/services/OperationalInsights/workspaces/alerts.yaml
@@ -476,7 +476,7 @@
       - '*'
     failingPeriods:
       numberOfEvaluationPeriods: 4
-      minFailingPeroidsToAlert: minFailingPeroidsToAlert
+      minFailingPeriodsToAlert: 3
     alertSensitivity: Medium
 - name: Average_Bytes Received/sec
   description: 'Average_Bytes Received/sec. Supported for: Windows. Part of [metric
@@ -515,7 +515,7 @@
       - '*'
     failingPeriods:
       numberOfEvaluationPeriods: 4
-      minFailingPeroidsToAlert: minFailingPeroidsToAlert
+      minFailingPeriodsToAlert: 3
     alertSensitivity: Medium
 - name: Average_Total Bytes Transmitted
   description: 'Average_Total Bytes Transmitted. Supported for: Linux. Part of [metric
@@ -554,7 +554,7 @@
       - '*'
     failingPeriods:
       numberOfEvaluationPeriods: 4
-      minFailingPeroidsToAlert: minFailingPeroidsToAlert
+      minFailingPeriodsToAlert: 3
     alertSensitivity: Medium
 - name: Average_Total Bytes Received
   description: 'Average_Total Bytes Received. Supported for: Linux. Part of [metric
@@ -593,7 +593,7 @@
       - '*'
     failingPeriods:
       numberOfEvaluationPeriods: 4
-      minFailingPeroidsToAlert: minFailingPeroidsToAlert
+      minFailingPeriodsToAlert: 3
     alertSensitivity: Medium
 - name: Event
   description: 'Event. Supported for: Windows. Part of [metric alerts for logs feature](https://aka.ms/am-log-to-metric).'

diff --git a/services/Sql/servers/alerts.yaml b/services/Sql/servers/alerts.yaml
@@ -109,7 +109,7 @@
     criterionType: DynamicThresholdCriterion
     failingPeriods:
       numberOfEvaluationPeriods: 5
-      minFailingPeroidsToAlert: minFailingPeroidsToAlert
+      minFailingPeriodsToAlert: 5
     alertSensitivity: Low
   references:
   - name: Monitor Azure SQL Database with metrics and alerts

diff --git a/services/Web/serverFarms/alerts.yaml b/services/Web/serverFarms/alerts.yaml
@@ -150,7 +150,7 @@
     criterionType: DynamicThresholdCriterion
     failingPeriods:
       numberOfEvaluationPeriods: 4
-      minFailingPeroidsToAlert: minFailingPeroidsToAlert
+      minFailingPeriodsToAlert: 4
     alertSensitivity: Low
 - name: TcpEstablished
   description: The average number of sockets in ESTABLISHED state across all the instances

diff --git a/services/Web/sites/alerts.yaml b/services/Web/sites/alerts.yaml
@@ -305,7 +305,7 @@
     criterionType: DynamicThresholdCriterion
     failingPeriods:
       numberOfEvaluationPeriods: 4
-      minFailingPeroidsToAlert: minFailingPeroidsToAlert
+      minFailingPeriodsToAlert: 4
     alertSensitivity: Low
   references:
   - name: Understand App Service Metrics
@@ -426,7 +426,7 @@
     criterionType: DynamicThresholdCriterion
     failingPeriods:
       numberOfEvaluationPeriods: 4
-      minFailingPeroidsToAlert: minFailingPeroidsToAlert
+      minFailingPeriodsToAlert: 4
     alertSensitivity: Low
   references:
   - name: Understand App Service Metrics

diff --git a/tooling/query-metrics-alerts/analysis_query.kql b/tooling/query-metrics-alerts/analysis_query.kql
@@ -179,6 +179,6 @@ rulesExpanded
     (
         resourceTypes
     ) on resourceType
-| extend failingPeriods = iif(criterionType =~ "DynamicThresholdCriterion", bag_pack("numberOfEvaluationPeriods", numberOfEvaluationPeriods, "minFailingPeriodsToAlert", "minFailingPeriodsToAlert"), "")
+| extend failingPeriods = iif(criterionType =~ "DynamicThresholdCriterion", bag_pack("numberOfEvaluationPeriods", numberOfEvaluationPeriods, "minFailingPeriodsToAlert", minFailingPeriodsToAlert), "")
 | project resourceType, numRulesRt, metricName, numRules, operator, timeAggregation, criterionType, frequency, windowSize, severity, dimensions, threshold, alertSensitivity, failingPeriods
 | order by resourceType asc, numRules desc