Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature enhancement]: Make it easier to create setDefinitions from Services #383

Open
1 task done
riosengineer opened this issue Oct 18, 2024 · 3 comments
Open
1 task done
Labels
AMBA Core Issues / PR's related AMBA Core question Further information is requested

Comments

@riosengineer
Copy link
Contributor

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Description

Hi team,

My scenario:

I have the ALZ Pattern deployed, this is great. It is deployed via enterprise policy as code from https://github.com/anwather/amba-export. I now want to incorporate more baseline alerts from the services provided by AMBA, also via EPAC.

My problem:

I now want to selectively take services from: https://azure.github.io/azure-monitor-baseline-alerts/services/, say SQL/Servers, and grab every definition, adding to my policyDefinitions and make these a policySetDefinitions. Then I can assign them wherever I see fit for alerting in my Azure estate (landing zones). Currently there is no way for me to do this, mostly because I don't think there is any setDefinition so the definitions will never load in Azure Policy.

I did try to take all the definitions and load them in Azure but it complains about 'Evaluation result of language expression '[[parameters('MonitorDisableTagValues')]' is type 'String', expected type is 'Array' (I have seen other issues on this).

How can I achieve this? Is this something AMBA would be open to providing a process for?

Some relevant context also: Azure/enterprise-azure-policy-as-code#788

@riosengineer riosengineer added the question Further information is requested label Oct 18, 2024
@Brunoga-MS Brunoga-MS added the AMBA Core Issues / PR's related AMBA Core label Oct 18, 2024
@riosengineer
Copy link
Contributor Author

Also relevant amba issue that is very similar ask: #214

@JoeyBarnes
Copy link
Collaborator

JoeyBarnes commented Oct 21, 2024

@riosengineer - Thank you for the feedback. We don't have a way to do this directly in AMBA today, but we are open to creating a process around this. I will add this request to the backlog for further consideration.

@riosengineer
Copy link
Contributor Author

@riosengineer - Thank you for the feedback. We don't have a way to do this directly in AMBA today, but we are open to creating a process around this. I will add this request to the backlog for further consideration.

Thank you Joey. I genuinely think this would be a great evolution to AMBA especially for enterprise customers who largely adopt EPAC.

In addition, it seems any Services Azure Policy definition I try and deploy to Azure has errors like the one referenced in my OP. Is this a separate issue? I was hoping to at least not get blocked for now by trying to create some of my own, but I can't deploy any Services definitions to Azure Policy (that I've tried) because of the above error. Any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AMBA Core Issues / PR's related AMBA Core question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants