Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditions that determine when the Alert Processing Rule should trigger #367

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conditions that determine when the Alert Processing Rule should trigger #367

wants to merge 2 commits into from

Conversation

JamesDLD
Copy link

@JamesDLD JamesDLD commented Oct 8, 2024 •
edited
Loading

Overview/Summary

Permit end users to apply conditional filters when alert will be triggered. This PR solves #366.

This PR adds

  1. The parameter 'AlertProcessingRuleConditions' on the policy definition 'Deploy_AlertProcessing_Rule'.

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@arjenhuitema arjenhuitema added Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern Area: Policy 📝 Issues / PR's related to Policy labels Oct 9, 2024
@Brunoga-MS
Copy link
Contributor

@Alboroni any news about this one? is it something we can approve and that integrates/aligns with your PR?

@Alboroni
Copy link
Contributor

@Brunoga-MS yes, this will be part of my pull PR however it will add extra parameter is policy so need to confirm if breaking change or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brunoga-MS Brunoga-MS Awaiting requested review from Brunoga-MS

@Alboroni Alboroni Awaiting requested review from Alboroni

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Area: Policy 📝 Issues / PR's related to Policy Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JamesDLD @Brunoga-MS @Alboroni @arjenhuitema