Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EG] timestamp fix #31269

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[EG] timestamp fix #31269

wants to merge 2 commits into from
+5 −7

Conversation

l0lawrence
Copy link
Member

@l0lawrence l0lawrence commented Oct 28, 2024 •
edited
Loading

Fixes #31250

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 28, 2024 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named Swagger BreakingChange has failed. To unblock this PR, follow the process at aka.ms/brch.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 28, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
.Net Azure.Messaging.EventGrid.SystemEvents https://apiview.dev/Assemblies/Review/3e102a891e5445af8be8cde833dbb702?revisionId=dc070f946aac4398ac78fdf298bd2117
Python azure-eventgrid https://apiview.dev/Assemblies/Review/c554ddbabc6e40348998b1656e0ff585?revisionId=6302c44c81a54214a424aea9d0cf8e69
Swagger Microsoft.EventGrid https://apiview.dev/Assemblies/Review/8dab2e78889f4bf4a935473df37e62bf?revisionId=7fedf5cfd57041af97086275f25af0e3

@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane TypeSpec Authored with TypeSpec labels Oct 28, 2024
This was referenced Oct 28, 2024
Draft
Draft
@l0lawrence l0lawrence marked this pull request as ready for review October 31, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kishp01 Kishp01 Awaiting requested review from Kishp01 Kishp01 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane Event Grid TypeSpec Authored with TypeSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] ScheduledOn timestamp is declared with the wrong TypeSpec type
2 participants
@l0lawrence @AzureRestAPISpecReview