Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Keyvault rbac DataAction miss out the keys/rotation/action #31286

Open
wuxu92 opened this issue Oct 29, 2024 · 1 comment
Open

[BUG] Keyvault rbac DataAction miss out the keys/rotation/action #31286

wuxu92 opened this issue Oct 29, 2024 · 1 comment
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. data-plane

Comments

@wuxu92
Copy link

wuxu92 commented Oct 29, 2024

API Spec link

API Spec version

7.5

Describe the bug

As the Local RBAC built-in roles for Managed HSM documentation described there is a keys/rotate/action permission and the key-rotation requires the keys/rotate/action permission to rotate the Managed HSM key. but the permission list for data actions in the swagger missed the rotate item:

"DataAction": {
"type": "string",
"description": "Supported permissions for data actions.",
"enum": [
"Microsoft.KeyVault/managedHsm/keys/read/action",
"Microsoft.KeyVault/managedHsm/keys/write/action",
"Microsoft.KeyVault/managedHsm/keys/deletedKeys/read/action",
"Microsoft.KeyVault/managedHsm/keys/deletedKeys/recover/action",
"Microsoft.KeyVault/managedHsm/keys/backup/action",
"Microsoft.KeyVault/managedHsm/keys/restore/action",
"Microsoft.KeyVault/managedHsm/roleAssignments/delete/action",
"Microsoft.KeyVault/managedHsm/roleAssignments/read/action",
"Microsoft.KeyVault/managedHsm/roleAssignments/write/action",
"Microsoft.KeyVault/managedHsm/roleDefinitions/read/action",
"Microsoft.KeyVault/managedHsm/roleDefinitions/write/action",

Expected behavior

The Microsoft.KeyVault/managedHsm/keys/rotate/action should be included in the DataAction list.

Actual behavior

No rotate permission in Swagger definition, so the generated SDK also lacks this item.

Reproduction Steps

https://github.com/tombuildsstuff/kermit/blob/654702e0718c3aa7f9644c29feae5e3817e01bc2/sdk/keyvault/7.4/keyvault/enums.go#L42-L70

Environment

No response

@wuxu92 wuxu92 added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Oct 29, 2024
@v-jiaodi
Copy link
Member

@jlichwa Please help take a look, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. data-plane
Projects
None yet
Development

No branches or pull requests

3 participants