Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Confidential Computing Ledger - Azure Confidential Ledger] API Review #31827

Closed
azure-sdk opened this issue Dec 10, 2024 · 4 comments · Fixed by #31903
Closed

[Azure Confidential Computing Ledger - Azure Confidential Ledger] API Review #31827

azure-sdk opened this issue Dec 10, 2024 · 4 comments · Fixed by #31903
Assignees
Labels
API Review Scoping This is an issue that will track work on a specific set of API changes.

Comments

@azure-sdk
Copy link
Collaborator

New API Review meeting has been requested.

Service Name: Azure Confidential Computing Ledger - Azure Confidential Ledger
Review Created By: Andrea Piccione
Review Date: 01/16/2025 04:00 PM PT
Release Plan: 1526
PR:
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided

Description: New API for user defined functions in Azure Confidential Ledger

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

@azure-sdk azure-sdk added the API Review Scoping This is an issue that will track work on a specific set of API changes. label Dec 10, 2024
@azure-sdk
Copy link
Collaborator Author

Meeting updated by Andrea Piccione

Service Name: Azure Confidential Computing Ledger - Azure Confidential Ledger
Review Created By: Andrea Piccione
Review Date: 01/16/2025 04:00 PM PT
Release Plan: 1526
PR: #31903
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided

Description: New API for user defined functions in Azure Confidential Ledger

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

@azure-sdk
Copy link
Collaborator Author

Meeting updated by Andrea Piccione

Service Name: Azure Confidential Computing Ledger - Azure Confidential Ledger
Review Created By: Andrea Piccione
Review Date: 01/16/2025 04:00 PM PT
Release Plan: 1526
PR: #31903
Hero Scenarios Link: here
Core Concepts Doc Link: here

Description: New API for user defined functions in Azure Confidential Ledger.

Slides: https://microsofteur.sharepoint.com/:p:/t/AzureLedger/ET40hdMzoG1BqVpD6OTGrOoBQV1EpFu8aIh7s122ZaQ0sA?e=ZPqQHX

Design document: https://microsofteur.sharepoint.com/:w:/t/AzureLedger/Efq3bqzHrwNMrDn_V8JYa_gBlvD4iQe6vkIlG7b05C9kxA?e=jRegPs

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

@andpiccione andpiccione self-assigned this Jan 14, 2025
@mikekistler
Copy link
Member

Follow-up tasks from API Review 1/17/25 (AI generated)

  • Security Review: Conduct a security review for the user-defined functions feature to ensure it meets all security standards. (Andrea)
  • Alternative Proposals: Explore and present alternative proposals for executing user functions, such as using pipeline capabilities or callbacks. (Andrea)
  • Customer Feedback: Engage with customers to gather feedback on practical use cases for the user-defined functions feature. (Andrea)
  • API Naming: Consider renaming the pre and post triggers to avoid confusion with traditional triggers, possibly to pre-processing and post-processing functions. (Andrea)
  • Swagger API Check: Post a question on the engineering systems teams channel to resolve the Swagger API View check issue. (Andrea)
  • Security Review Confirmation: Confirm if the user-defined endpoints feature went through a security review and ensure the same process for the new feature. (Andrea)

@andpiccione
Copy link
Member

A few updates and follow-up from the API review:

  • After checking with my team on the security risks of executing custom code in the sandboxed environment of our ledger services, we confirmed that this was already addressed during the threat model review of Azure Managed CCF and the refresh threat model review of CCF this year. We have explained the mitigations in place (heap, stack, runtime caps, access control to different tables, etc.), and no additional steps were required after the review. UDFs build on the same functionality without adding extra risks compared to the existing user-defined endpoints, so this matter should be addressed.

  • We have decided to rename triggers to hooks, as this term better represents the concept of tapping into specific points of an operation to execute custom logic before and after a write transaction. This change also allows for the future implementation of real triggers that automatically run upon certain conditions, which we plan to introduce in a later iteration of this feature (based on customer's feedback and demand).

  • The Swagger API check failure has been resolved and all comments have been addressed. I have updated the PR to include the feedback received during the review meeting and all CI checks are successful: [Microsoft.ConfidentialLedger] [DataPlane] Add new API version preview/2024-12-09-preview by andpiccione · Pull Request #31903 · Azure/azure-rest-api-specs

@github-project-automation github-project-automation bot moved this from Triage to Done in API Stewardship Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Review Scoping This is an issue that will track work on a specific set of API changes.
Projects
Status: Done
3 participants