-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebasing dev-cognitiveservices-Language-2022-03-01-preview onto main #18538
Closed
abhahn
wants to merge
386
commits into
Azure:dev-cognitiveservices-Language-2022-03-01-preview
from
abhahn:rebase-march1
Closed
Rebasing dev-cognitiveservices-Language-2022-03-01-preview onto main #18538
abhahn
wants to merge
386
commits into
Azure:dev-cognitiveservices-Language-2022-03-01-preview
from
abhahn:rebase-march1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…7705) * Add description to formData in loadtest data-plane API * Modify description for loadtest upload route in data-plane API
…zure#17715) * Adding missing properties from GA swagger * Adding object property
Co-authored-by: Riya Simon <[email protected]>
… profile update properties (Azure#17890) * Adding originResponseTimeoutSeconds and Identity to profile update properties * Fix json syntax * Fix incorrect type for compressionSettings and SharedPrivateLinkkResourceProperties * Add type info to fix lint error Co-authored-by: Sindhuri <[email protected]> Co-authored-by: Bo Zhang <[email protected]>
* Copy of previous API v2016-05-01 * URP api 2021-07-01 * Update examples * Validation issue fix * validateion fix * validation fix * Add API 2021-07-01 as stable version * Update readme for new api * New api in readme * Config fix * Remove input-file Invalid yaml Co-authored-by: JianyeXi <[email protected]> * Correct reference readme.md Co-authored-by: JianyeXi <[email protected]> * Fix validation errors * Fix validation * Validate fix * update validateion fix * Refactoring Co-authored-by: JianyeXi <[email protected]>
* add swagger changes for byok * fix comment * fix identity * add byok example * attach example * fix comment * fix update * fix comment * fix comment
Co-authored-by: Steven Vukelich <[email protected]>
* Adding xms-ids to CognitiveServices * corrections after rebase * Update PR per feedback Co-authored-by: Yanming Tang <[email protected]>
* add azure function * add authenticationMode to blob input, AzFunction and DW ex files * update api version in 2021 preview ex files * fix api version * fix password * try to run model validation again Co-authored-by: Roslyn Lu <[email protected]>
Co-authored-by: Steven Vukelich <[email protected]>
…7803) Co-authored-by: Steven Vukelich <[email protected]>
Co-authored-by: Steven Vukelich <[email protected]>
* Adding xms-ids for ApiManagement * corrections after rebase
* Remove LegacyMicrosoftAccount as it is not required * Remove unused properties
…Azure#17917) * Update the label property of request body of find target resource api It should be a map with the key of "label". Right now the request body is defined as: { "key":"value" } But it should be changed to: { "labels":{ "key":"value" } } * Update a description * Fix validation check of example json file for find target resource group api
* Fix * operation Co-authored-by: Roy Reinhorn <[email protected]>
* [Go] Add batch tag 20220224 * remove healthcareapis
* Expand comment on managedIdentityResourceId * Change according to Oren's review
Co-authored-by: Steven Vukelich <[email protected]>
Co-authored-by: Steven Vukelich <[email protected]>
Co-authored-by: Ochi <[email protected]>
…ingexperimentation and machinelearningservices (Azure#17734) * add xmsids for machinelearning rps * update inner properties * address code review comments
…ble/2021-06-01 (Azure#17836) * swagger completeness fix for asyncOperations status. * Update readme.python.md Co-authored-by: Priyankar Gupta <[email protected]> Co-authored-by: Yuchao Yan <[email protected]>
…hanges LIST operation (Azure#17595) * Update changes.json
This was referenced Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.