Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look at possibly changing a few things in ci.yml #43984

Open
JimSuplizio opened this issue Jan 30, 2025 · 0 comments
Open

Look at possibly changing a few things in ci.yml #43984

JimSuplizio opened this issue Jan 30, 2025 · 0 comments
Assignees
Labels
EngSys This issue is impacting the engineering system.

Comments

@JimSuplizio
Copy link
Member

This issue is due to comments made by @weshaggard in this PR review.

  1. Look at using verify-readmes.yml in all cases.
  2. Look at using verify-links.yml in call cases
  3. Look at using verify-changelogs.yml in call cases.

There are a couple of issues with these

  1. In order to do these, we'd have to make the Analyze job depend on the Build job which is not something I'm wanting to do, I don't like the idea of losing the parallelization. For something like core, this isn't a big deal but for smaller pipelines, like template it'll overall increase the run time.
  2. Even if we did the first item, above, there would still need to be a check for the PR pipeline in the case of verify-samples.yml since I'd need to get the ServiceDirectory list from the diff.json
@JimSuplizio JimSuplizio added the EngSys This issue is impacting the engineering system. label Jan 30, 2025
@JimSuplizio JimSuplizio self-assigned this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EngSys This issue is impacting the engineering system.
Projects
Status: 🤔 Triage
Development

No branches or pull requests

1 participant