ci: skip key download if preflight is true (#1609)

Signed-off-by: Anish Ramasekar <[email protected]>

Author: aramase

scripts/create-kind-cluster.sh

@@ -94,7 +94,7 @@ EOF
 }
 
 download_service_account_keys() {
-  if [[ -z "${SERVICE_ACCOUNT_KEYVAULT_NAME:-}" ]]; then
+  if [[ -z "${SERVICE_ACCOUNT_KEYVAULT_NAME:-}" ]] || [[ "${SKIP_PREFLIGHT:-}" == "true" ]]; then
     return
   fi
   az keyvault secret show --vault-name "${SERVICE_ACCOUNT_KEYVAULT_NAME}" --name sa-pub | jq -r .value | base64 -d > "${SERVICE_ACCOUNT_KEY_FILE}"

test/e2e/proxy_test.go

@@ -40,7 +40,7 @@ var _ = ginkgo.Describe("Proxy [LinuxOnly] [AKSSoakOnly]", func() {
 			serviceAccount,
 			"mcr.microsoft.com/azure-cli",
 			nil,
-			[]string{"/bin/sh", "-c", fmt.Sprintf("az login -i -u %s --allow-no-subscriptions --debug; sleep 3600", clientID)},
+			[]string{"/bin/sh", "-c", fmt.Sprintf("az login -i --client-id %s --allow-no-subscriptions --debug; sleep 3600", clientID)},
 			nil,
 			proxyAnnotations,
 			map[string]string{useWorkloadIdentityLabel: "true"},