Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter rule suggestion: Flag sensitive values that are used in non-sensitive places #16252

Open
anthony-c-martin opened this issue Jan 31, 2025 · 0 comments

Comments

@anthony-c-martin
Copy link
Member

Maybe a separate issue, but we should in general be flagging whenever a sensitive value is assigned to a non-sensitive slot or vice versa. For example, the following template raises no diagnostics but should raise two:

@secure()
param secret string

param nonSensitive string

resource e 'Microsoft.CostManagement/exports@2024-08-01' = {
  name: secret    // <-- Should flag assignment of sensitive data to non-sensitive slot
  properties: {
    definition: {
      timeframe: 'BillingMonthToDate'
      type: 'Usage'
    }
    deliveryInfo: {
      destination: {
        container: 'containerName'
        sasToken: nonSensitive   // <-- Should flag assignment of non-sensitive data to sensitive slot
      }
    }
  }
}

We should be able to do this based on existing type validation flags. I'm not sure if we accurately track "taint," though (i.e., is a variable whose value is based on a secure parameter itself be flagged as secure?).

Originally posted by @jeskew in #15835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants