Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Nuget binary from sources #402

Open
karolz-ms opened this issue Apr 22, 2022 · 1 comment
Open

Remove Nuget binary from sources #402

karolz-ms opened this issue Apr 22, 2022 · 1 comment
Labels
engineering Engineering/infrastructure/ease of development enhancements

Comments

@karolz-ms
Copy link
Collaborator

We have a Nuget binary checked in into our sources (tools folder). A better way would be to rely on a copy that exists in the build environment.

The binary is used by tools\restore.cmd script. A straightforward attempt to replace the use with dotnet restore failed--the latter does not seem to properly restore the old-style signing projects that we use for binary and Nuget package signing.

@karolz-ms karolz-ms added the engineering Engineering/infrastructure/ease of development enhancements label Apr 22, 2022
@xiaomi7732
Copy link
Member

Lesson learned. @karolz-ms, have you tried to use this build step to bring in the binary:

        - task: NuGetToolInstaller@1
          inputs:
            versionSpec: 
            checkLatest: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Engineering/infrastructure/ease of development enhancements
Projects
None yet
Development

No branches or pull requests

2 participants