Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Move e2e from bash/gh actions to golang #240

Open
davidgamero opened this issue Dec 12, 2023 · 3 comments
Open

Proposal: Move e2e from bash/gh actions to golang #240

davidgamero opened this issue Dec 12, 2023 · 3 comments

Comments

@davidgamero
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The current draft e2e is written in bash across a series of files, which yield a set of tremendous github workflow yamls

This cannot be run locally easily, and has a high adoption cost to get into the build-test-iteration loop

Migrating to a go-based testing framework for e2e would allow the tests to be run locally easier, and make them much faster to test

Describe alternatives you've considered
Keep the tests in gh actions

Additional context
something like the testing implemented in https://github.com/Azure/aks-app-routing-operator by @OliverMKing

@OliverMKing
Copy link
Contributor

You should use this if testing on a private cluster isn't a requirement. Our current e2e tests in Draft use a local cluster which works nicely with the k8s sig e2e framework.

@davidgamero
Copy link
Collaborator Author

this is a good idea, it looks like the k8s-e2e-framework doesn't support kubectl apply, so we'd test by marshaling the created manifests into k8s objects or using the corresponding clients to bake for helm/kustomize

@davidgamero
Copy link
Collaborator Author

testing the oidc github integration would need a different approach since it uses aks-specific features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants