Proposed Change to setup.py for Environment Variables

[VAN613]

Hello,

I would like to propose a change to the setup.py file. Currently, the file contains the following lines:

deployment_id = "text-embedding-ada-002"  # Example deployment ID
model_name = "text-embedding-ada-002"

I would like to modify it to use environment variables as follows:

import os
deployment_id = os.getenv("AZURE_OPENAI_EMBEDDING_DEPLOYMENT")
model_name = os.getenv("AZURE_OPENAI_EMBEDDING_MODEL")

Is there any issue with making this change? Thank you for your consideration.

Best regards,