Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Cross build #503

Open
rmr opened this issue Feb 1, 2018 · 2 comments
Open

Cross build #503

rmr opened this issue Feb 1, 2018 · 2 comments

Comments

@rmr
Copy link

rmr commented Feb 1, 2018

I have now built the source to be used on ARM platform using openwrt (not tested yet).

I have had to make changes in the CMake files. I am not very experienced with CMake, so my changes are hacks.

  1. Could libuv be a possible external dependency? Not automatically clone and build the submodule? The link flags are statically set to the submodules directory, not the linker flags.

Cheers,
Ryan

@darobs
Copy link
Contributor

darobs commented Feb 1, 2018

Hello @rmr

It's a common pattern to build libuv into the project like this, and we chose that way because we knew it would work. However, I've noticed how problematic it's been for cross-compiling.

I'm not opposed to making a dependency on libuv, and I'll put it on our backlog. In the meantime, if you have changes and are willing to submit a pull request, we'd be glad to look at it.

@damonbarry
Copy link
Member

I think PR #568 will fix this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants