Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle correctly Mark/None case: no single gateway owns the device connection to IoT Hub #1587

Open
spygi opened this issue Mar 3, 2022 · 0 comments
Open

Handle correctly Mark/None case: no single gateway owns the device connection to IoT Hub #1587

spygi opened this issue Mar 3, 2022 · 0 comments
Labels
bug Something isn't working
Milestone
vNext

Comments

@spygi
Copy link
Contributor

spygi commented Mar 3, 2022 •
edited
Loading

When deduplication strategy is Mark or none, there is no single "owner" gateway of the connection to IoT Hub. Therefore the nullable IsConnectionOwner flag should be kept null and we should not attempt to close the connection (allowing the connection ping pong to happen). This is already a documented limitation of the Mark and none strategies.

Acceptance criteria

  • Ensure for Mark/None strategies we don't set a connection owner and we don't close the connection.
  • Unit or simulation test covering this case.
This was referenced Mar 3, 2022
Closed
Merged
@spygi spygi changed the title Handle correctly Mark case: connectionOwner should be null for all LNSs as there is no single owner Handle correctly Mark/None case: no single gateway owns the device connection to IoT Hub Mar 3, 2022
@spygi spygi added the bug Something isn't working label Mar 3, 2022
@spygi spygi added this to the vNext milestone Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
vNext
Development

No branches or pull requests
1 participant
@spygi