Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Testing of release workflow steps on PR creation #1943

Open
5 tasks
ouphi opened this issue Oct 28, 2022 · 0 comments
Open
5 tasks

[Story] Testing of release workflow steps on PR creation #1943

ouphi opened this issue Oct 28, 2022 · 0 comments
Labels
story User Story

Comments

@ouphi
Copy link
Collaborator

ouphi commented Oct 28, 2022

Note: Given the context this story is not a priority and might be overkill - Please align with the repo owners before starting on this story.

Description

The release workflow will not be running often, it only run if a user triggers manually.
There is a risk that this workflow gets broken without us knowing it. For example, if somebody adds a mandatory arg to the basic station Dockerfile, the job building the image would be broken, but we would only notice it when creating a release.

A solution could be:

  • Trigger the release workflow on PR
  • Disable steps that we only want to happen on a real release. For example pushing images and the release creation would be disabled when the trigger is pull_request.

Acceptance criteria

  • The risk to break the release workflow is minimised
  • Most of the release workflow is tested on PR.

Tasks

  • Add a pull_request trigger
  • Disable release creation if the trigger is not workflow_dispatch
  • Disable publishing images to docker hub if the trigger is not workflow_dispatch
@ouphi ouphi added the story User Story label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story User Story
Projects
None yet
Development

No branches or pull requests

1 participant