Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple key vault support #1088

Open
davildaran opened this issue Mar 2, 2023 · 1 comment
Open

multiple key vault support #1088

davildaran opened this issue Mar 2, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@davildaran
Copy link

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

The ability to specify multiple Azure Key Vaults/SecretProviderClasses for the same service in the same namespace.

E.g. serviceA/dev/secret-provider-class.yaml

apiVersion: secrets-store.csi.x-k8s.io/v1
kind: SecretProviderClass
metadata:
  name: secrets
  namespace: serviceA
spec:
  provider: azure
  parameters:
    usePodIdentity: "false"
    useVMManagedIdentity: "true"
    userAssignedIdentityID: ...
    keyvaultName: serviceA-keyvault1
    cloudName: ""
    tenantId: ...
---
apiVersion: secrets-store.csi.x-k8s.io/v1
kind: SecretProviderClass
metadata:
  name: secrets
  namespace: serviceA
spec:
  provider: azure
  parameters:
    usePodIdentity: "false"
    useVMManagedIdentity: "true"
    userAssignedIdentityID: ...
    keyvaultName: serviceA-keyvaultB
    cloudName: ""
    tenantId: ...

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Looked into a few ways of trying to specify this. kustomize build path/to/dev/ yields valid yaml but overrides to just (1) single SecretProviderClass definition.

Environment:

  • Secrets Store CSI Driver version: (use the image tag): secrets-store.csi.x-k8s.io/v1
  • Azure Key Vault provider version: (use the image tag):
  • Kubernetes version: (use kubectl version): 1.26
  • Cluster type: (e.g. AKS, aks-engine, etc): AKS
@davildaran davildaran added the enhancement New feature or request label Mar 2, 2023
@JorTurFer
Copy link

I'd say that this is currently supported. I mean, just name them differently and mount the one by one into your workload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants