Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up agents #11

Closed
wants to merge 10 commits into from
Closed

Clean up agents #11

wants to merge 10 commits into from

Conversation

mozts2005
Copy link
Contributor

updated docker startup scripts fix #3

@mozts2005 mozts2005 mentioned this pull request Jan 20, 2021
Open
@jcorioland
Copy link
Collaborator

@mozts2005 thanks for this PR!
Could you please:

  1. update your fork with the last version of master so we can run test using TF 0.14
  2. add a test that checks the agent have actually been deleted from the pool before the test infrastructure remove it (to validate the use case, actually).

Thanks

@mozts2005
Copy link
Contributor Author

Happy to try and add a test case will have to do some learning of the system.

@mozts2005 mozts2005 marked this pull request as draft January 21, 2021 14:27
@jcorioland
Copy link
Collaborator

@mozts2005 thank you! Let me know if you have some question regarding the testing part.

@mozts2005 mozts2005 marked this pull request as ready for review January 25, 2021 23:50
jcorioland
jcorioland reviewed Jan 26, 2021
View reviewed changes
Copy link
Collaborator

@jcorioland jcorioland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mozts2005 thanks for the push with tests, this is very good stuff. I've made a few comments of things that can be improved. What do you think? Otherwise, this looks good to me. I will run CI on it to ensure this is working.

test/azure_devops_agent_aci_test.go Show resolved Hide resolved
test/azure_devops_agent_aci_test.go Outdated Show resolved Hide resolved
jcorioland
jcorioland requested changes Jun 4, 2021
View reviewed changes
Copy link
Collaborator

@jcorioland jcorioland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cf. comments above.

@jcorioland
Copy link
Collaborator

Closing this PR as there is no activity for about a year.
Feel free to reopen if needed @mozts2005. Thank you!

@jcorioland jcorioland closed this Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcorioland jcorioland jcorioland requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up agents from pool when Terraform destroy is called
2 participants
@mozts2005 @jcorioland