Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Question/Feedback]: dns_servers should be applied in the same order they were passed to the module #181

Open
1 task done
Cyr-Az opened this issue Dec 7, 2024 · 1 comment
Labels
Language: Terraform 🌐 This is related to the Terraform IaC language Status: Long Term ⏳ We will do it, but will take a longer amount of time due to complexity/priorities Type: Question/Feedback 🙋 Further information is requested or just some feedback

Comments

@Cyr-Az
Copy link

Cyr-Az commented Dec 7, 2024

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Description

Hi,

The ordering of dns servers configured on a vnet does matter (see https://learn.microsoft.com/en-us/azure/virtual-network/manage-virtual-network#change-dns-servers ), so it would be better if the module could keep the order in which the dns server list is passed to the module.

I guess that would require changing the dns_servers variable type from a set to a list, maybe with distinct() to prevent duplicates.

Thanks :)

@Cyr-Az Cyr-Az added Language: Terraform 🌐 This is related to the Terraform IaC language Needs: Triage 🔍 Maintainers need to triage still Type: Question/Feedback 🙋 Further information is requested or just some feedback labels Dec 7, 2024
@jaredfholgate
Copy link
Member

@Cyr-Az I think distinct would break the ordering, but we could add validation to the input variable. We are happy to accept a PR if you need this soon.

@jaredfholgate jaredfholgate added Status: Long Term ⏳ We will do it, but will take a longer amount of time due to complexity/priorities and removed Needs: Triage 🔍 Maintainers need to triage still labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language: Terraform 🌐 This is related to the Terraform IaC language Status: Long Term ⏳ We will do it, but will take a longer amount of time due to complexity/priorities Type: Question/Feedback 🙋 Further information is requested or just some feedback
Projects
None yet
Development

No branches or pull requests

2 participants