feat: support for azure AD groups #155 #375
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/summary
This PR introduces support for Entra ID (AAD) groups.
I have thought it might be nice to be able to specify names as well as object IDs, that's why the members + owners contain a map of object ids. This would introduce several "data sources" into the module to make these translations, which may be an undesirable dependency.
This PR fixes/adds/changes/removes
Breaking changes
n/a - new functionality
Testing evidence
Please provide testing evidence to show that your Pull Request works/fixes as described and documented above.
I'm using an integration branch here which is testing a number of fixes including this one, the inputs are:
As part of this pull request I have
make fmt&make docsto format your code and update documentation.Deployment testing looks good, guidance with unit testing would be appreciate 😊, i'm not familiar with the approach.