Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow for resources to be made in a common resource group #371

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kewalaka
Copy link
Contributor

Overview/summary

Add a dependency on resources that go in the resource group. This allows a scenario where a single common resource group is used for RG-scoped components.

To make use of this, for example:

resource_groups:
  core-rg:
    name: rg-example
    location: australiaeast

virtual_networks:
    resource_group_name: rg-example
    resource_group_creation_enabled: false

This PR fixes/adds/changes/removes

  1. fixes feat: resource group dependencies #358

Breaking changes

None.

Testing evidence

Testing has been conducted on a private repo, will see if i can find some results to share.

As part of this pull request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Run and make fmt & make docs to format your code and update documentation.
  • Created unit and deployment tests and provided evidence.
  • Updated relevant and associated documentation.

@kewalaka kewalaka requested a review from a team as a code owner April 25, 2024 23:19
@kewalaka kewalaka changed the title wip: allow for resources to be made in a common resource group allow for resources to be made in a common resource group Apr 25, 2024
@kewalaka kewalaka changed the title allow for resources to be made in a common resource group fix: allow for resources to be made in a common resource group Jun 2, 2024
@kewalaka
Copy link
Contributor Author

kewalaka commented Oct 8, 2024

there was a linting issue here just noticed, just posted the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: resource group dependencies
2 participants