From 43dc76000ef0712c06346a30501faa8ea72ddb3c Mon Sep 17 00:00:00 2001 From: Sareh Heidari Date: Thu, 13 Feb 2020 17:15:10 +0000 Subject: [PATCH 1/3] Update visually hidden text to prevent splitting over multiple strings in rendered output --- packages/components/psammead-story-promo/CHANGELOG.md | 1 + packages/components/psammead-story-promo/package-lock.json | 2 +- packages/components/psammead-story-promo/package.json | 2 +- .../components/psammead-story-promo/src/IndexAlsos/index.jsx | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/components/psammead-story-promo/CHANGELOG.md b/packages/components/psammead-story-promo/CHANGELOG.md index 70af9d2069..772d394e51 100644 --- a/packages/components/psammead-story-promo/CHANGELOG.md +++ b/packages/components/psammead-story-promo/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | | ------- | ----------- | +| 4.0.0-alpha.11 | [PR#x](https://github.com/bbc/psammead/pull/x) Fix visually hidden text so it isn't split across multiple strings. | | 4.0.0-alpha.10 | [PR#3129](https://github.com/bbc/psammead/pull/3129) Talos - Bump Dependencies - @bbc/gel-foundations | | 4.0.0-alpha.9 | [PR#3107](https://github.com/bbc/psammead/pull/3107) Pass in dir prop to MediaIndicator in IndexAlsosContainer. | | 4.0.0-alpha.8 | [PR#3073](https://github.com/bbc/psammead/pull/3073) Use new major version of MediaIndicator. StoryPromo has updated styling around the MediaIndicator. Index Alsos test helper now using prop `isInline` for the MediaIndicator. | diff --git a/packages/components/psammead-story-promo/package-lock.json b/packages/components/psammead-story-promo/package-lock.json index a484b555a8..86b7bc6cc1 100644 --- a/packages/components/psammead-story-promo/package-lock.json +++ b/packages/components/psammead-story-promo/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-story-promo", - "version": "4.0.0-alpha.10", + "version": "4.0.0-alpha.11", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/components/psammead-story-promo/package.json b/packages/components/psammead-story-promo/package.json index 9142223c35..2aaa538f95 100644 --- a/packages/components/psammead-story-promo/package.json +++ b/packages/components/psammead-story-promo/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-story-promo", - "version": "4.0.0-alpha.10", + "version": "4.0.0-alpha.11", "main": "dist/index.js", "module": "esm/index.js", "sideEffects": false, diff --git a/packages/components/psammead-story-promo/src/IndexAlsos/index.jsx b/packages/components/psammead-story-promo/src/IndexAlsos/index.jsx index 244220b599..9e457341fa 100644 --- a/packages/components/psammead-story-promo/src/IndexAlsos/index.jsx +++ b/packages/components/psammead-story-promo/src/IndexAlsos/index.jsx @@ -66,7 +66,7 @@ const IndexAlsosLink = ({ <> {mediaIndicator} - {mediaType}, + {`${mediaType}, `} {children} From e8b6788db8259a7e786970c24b34f1d70fcb05e1 Mon Sep 17 00:00:00 2001 From: Sareh Heidari Date: Thu, 13 Feb 2020 17:29:15 +0000 Subject: [PATCH 2/3] Update snapshots --- .../src/IndexAlsos/__snapshots__/index.test.jsx.snap | 6 ++---- .../src/__snapshots__/index.test.jsx.snap | 6 ++---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/packages/components/psammead-story-promo/src/IndexAlsos/__snapshots__/index.test.jsx.snap b/packages/components/psammead-story-promo/src/IndexAlsos/__snapshots__/index.test.jsx.snap index 4792d77c07..92706c79c0 100644 --- a/packages/components/psammead-story-promo/src/IndexAlsos/__snapshots__/index.test.jsx.snap +++ b/packages/components/psammead-story-promo/src/IndexAlsos/__snapshots__/index.test.jsx.snap @@ -172,8 +172,7 @@ exports[`Index Alsos should render multiple correctly 1`] = ` - video - , + video, - video - , + video, - video - , + video, - video - , + video, Date: Thu, 13 Feb 2020 17:30:27 +0000 Subject: [PATCH 3/3] Update version --- packages/components/psammead-story-promo/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/psammead-story-promo/CHANGELOG.md b/packages/components/psammead-story-promo/CHANGELOG.md index 772d394e51..440616c1e6 100644 --- a/packages/components/psammead-story-promo/CHANGELOG.md +++ b/packages/components/psammead-story-promo/CHANGELOG.md @@ -3,7 +3,7 @@ | Version | Description | | ------- | ----------- | -| 4.0.0-alpha.11 | [PR#x](https://github.com/bbc/psammead/pull/x) Fix visually hidden text so it isn't split across multiple strings. | +| 4.0.0-alpha.11 | [PR#3136](https://github.com/bbc/psammead/pull/3136) Fix visually hidden text so it isn't split across multiple strings. | | 4.0.0-alpha.10 | [PR#3129](https://github.com/bbc/psammead/pull/3129) Talos - Bump Dependencies - @bbc/gel-foundations | | 4.0.0-alpha.9 | [PR#3107](https://github.com/bbc/psammead/pull/3107) Pass in dir prop to MediaIndicator in IndexAlsosContainer. | | 4.0.0-alpha.8 | [PR#3073](https://github.com/bbc/psammead/pull/3073) Use new major version of MediaIndicator. StoryPromo has updated styling around the MediaIndicator. Index Alsos test helper now using prop `isInline` for the MediaIndicator. |