Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sw.js file isn't created #122

Open
colenso opened this issue Mar 15, 2022 · 1 comment · May be fixed by #123
Open

sw.js file isn't created #122

colenso opened this issue Mar 15, 2022 · 1 comment · May be fixed by #123

Comments

@colenso
Copy link

colenso commented Mar 15, 2022

Not sure if this is a bug or if I haven't configured it correctly. But the sw.js file isn't getting created when I run my project on localhost after installing this addon. I can see that it should be created as part of the postprocessTree hook call but this hook isn't getting called for some reason.
@josex2r or @adrigzr can you help me figure this out?
@colenso
Copy link
Author

colenso commented Mar 15, 2022

It would be helpful to note that my project uses embroider. Maybe that hook isn't being called when using embroider? Found a related issue: embroider-build/embroider#112

@colenso colenso linked a pull request Mar 17, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add workaround for creating sw.js file for embroider project x-b-e/ember-cli-workbox
1 participant
@colenso