Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mysql service name typo #753

Closed
wants to merge 4 commits into from
Closed

Conversation

D3vil0p3r
Copy link

@D3vil0p3r D3vil0p3r commented Oct 21, 2024

Describe your changes

The MySQL service name is not mysql anymore but mysqld.

Issue ticket number and link (if there is one)

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I have added an entry to CHANGELOG.md
  • I have updated the documentation in docs/ (if applicable)

@D3vil0p3r D3vil0p3r marked this pull request as ready for review October 21, 2024 09:17
@D3vil0p3r
Copy link
Author

@vinnybod can you give a look to this simple PR?

@@ -63,7 +63,7 @@ jobs:
cache: 'poetry'
- name: Set up MySQL
run: |
sudo systemctl start mysql
sudo systemctl start mysqld

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find much info about whether to use mysql or mysqld, but I know the current behavior works for the OS that we test.

Do we need to add a check here like:

if systemctl list-units --type=service | grep -i mysqld > /dev/null; then
    sudo systemctl start mysqld
else
    sudo systemctl start mysql
fi

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I further verified. Your current code with mysql is right. I close this PR.

@D3vil0p3r D3vil0p3r closed this Nov 20, 2024
@D3vil0p3r D3vil0p3r deleted the patch-1 branch November 20, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants