Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple table schemas #28

Open
mark-walle opened this issue Jul 29, 2019 · 1 comment
Open

Support for multiple table schemas #28

mark-walle opened this issue Jul 29, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mark-walle
Copy link

The verifyBackup function on (this line)[https://github.com/BCDevOps/backup-container/blob/59699357cc6908bc9f1d29c907eec54fffc86762/docker/backup.sh#L1198] uses a WHERE table_schema='${TABLE_SCHEMA}' condition, with TABLE_SCHEMA defaulting to public.

This works well when there is only one table schema value; however, across multiple databases or even within the same database, there may be multiple differing table schema values. In that case, the condition above would miss those schema.

@WadeBarnes WadeBarnes added the help wanted Extra attention is needed label Jul 29, 2019
@WadeBarnes WadeBarnes added the enhancement New feature or request label Sep 12, 2019
@WadeBarnes
Copy link
Member

Initial support, as described above was added in PR #29.

Support for changing the TABLE_SCHEMA on a per database level would need to be added to the database specification in the settings/config.

Perhaps something like this;
<Hostname/>[:<Port/>]/<DatabaseName/>[.<SchemaName/>]
postgresql:5432/TheOrgBook_Database.my_schema
Where:

  • Database Serve Name: postgresql
  • Database Port (Optional): 5432
  • Database Name: TheOrgBook_Database
  • Schema Name (Optional): my_schema

@WadeBarnes WadeBarnes added the good first issue Good for newcomers label Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants