Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster ordinal and ordinal should be consistent #138

Open
hannes-ucsc opened this issue Mar 30, 2016 · 2 comments
Open

Cluster ordinal and ordinal should be consistent #138

hannes-ucsc opened this issue Mar 30, 2016 · 2 comments

Comments

@hannes-ucsc
Copy link
Contributor

The cluster ordinal is assigned as instances enter the running state. The ordinal is determined by an ordering on the composite key (launch time, private IP and instance ID) which is not necessarily consistent with the cluster ordinal.

We should include cluster name and cluster ordinal as the dominant members in the composite key of the ordinal ordering. The problem is that these two are derived from instance tags, not attributes of the boto.ec2.instance.Instance objects which is what the key function currently is limited to accessing.

We could bind() the instances before sorting them. This might be expensive.

We could access the instance.tags dictionary in the key function. Some tags might not be populated.

@hannes-ucsc hannes-ucsc changed the title cluster_ordinal and ordinal are inconsistent Cluster ordinal and ordinal should be consistent Mar 30, 2016
@hannes-ucsc
Copy link
Contributor Author

Thanks, @arkal for helping think this through.

@arkal
Copy link
Contributor

arkal commented Mar 30, 2016

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants