Feature/#240 스터디원 중복 추가 불가 기능 개발 #247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JJimini
reviewed
Dec 9, 2024
Comment on lines
+22
to
+23
| public void duplicateCheckStudyMember(final Long studyId, final Long memberId) { | ||
| if (studyRoleRepository.existsByStudyIdAndMemberId(studyId, memberId)) { |
There was a problem hiding this comment.
저희가 사용하는 단어 통일을 했습니다! (노션에 용어사전있음)
스터디(Study) - 참여자(Participant)
팀(Team) - 팀원(MemberTeam)
그래서 StudyMember가 아닌 Participant로 하면 좋을 것 같습니다!
Comment on lines
+11
to
+12
| Boolean existsByStudyIdAndMemberId(Long studyId, Long memberId); | ||
|
|
There was a problem hiding this comment.
existsByStudyIdAndMemberIdAndStudyRoleType, deleteByStudyIdAndMemberId 혹시 이거 어디갔는지 아시나요...?? 왜 없어졌을까요..?
Comment on lines
+87
to
+88
| final Long studyId = study.getId(); | ||
| final Member participant = createMember(); |
There was a problem hiding this comment.
participant도 좋지만 alreadyJoinedParticipant 같이 이 테스트의 의미가 잘 나타나는 이름으로 지으면 의미가 더 잘 전달될 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
close: #240
📝 작업 내용
💬 리뷰 요구사항(선택)