Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yessjun
reviewed
Mar 6, 2025
Comment on lines
+56
to
+61
| @PatchMapping("/myPage/members/{memberId}") | ||
| public ResponseEntity<Void> updateMyPage(@Valid @RequestBody final MyPageUpdateRequest request, | ||
| @PathVariable final Long memberId, @LoginMember final Member member) { | ||
| memberCommandService.updateMyPage(request, memberId, member.getId()); | ||
| return ResponseEntity.noContent().build(); | ||
| } |
There was a problem hiding this comment.
API 주소를 /myPage/members/{memberId}에서 /members/me로 수정하는게 어떨까요?
memberId와 로그인 member id 값을 서비스로 전달해서 값이 동일한지 검증하는 로직도 있는데 타인의 정보를 수정할 수 있는 API가 아니기 때문에 memberId 없이 로그인 정보 기반으로만 동작하도록 해도 좋을 것 같습니다.
Comment on lines
+6
to
+7
| @NotNull(message = "이름을 입력해주세요.") | ||
| String name |
There was a problem hiding this comment.
이 부분은 기획에서 정의되지 않았지만 일반적으로 공백 이름이 설정되면 안되기 때문에 @notblank로 검증하는게 좋을 것 같습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
close: #270
📝 작업 내용
💬 리뷰 요구사항