Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Edit the default interaction mode. #191

Open
4 tasks
allemangD opened this issue Jul 29, 2021 · 0 comments
Open
4 tasks

Make Edit the default interaction mode. #191

allemangD opened this issue Jul 29, 2021 · 0 comments
Labels
Category: Usability It's working but inefficient and convulated Status: Triage Issues/PRs that need to be triaged

Comments

@allemangD
Copy link
Collaborator

Working through #178 highlighted some unintuitive behavior behind the Explore and Edit modes. I'm opening this issue for some discussion about changing the default behavior when opening the app.

I also saw some similar confusion from Rusty during his demo regarding #182; he aligned the view to the specimen, but that work was undone once he clicked "Edit". That is similar #178, but has a different root cause. Personally, I've also made the same mistake while debugging.

The orientation of the slice is stored within the annotation; this is how multiple annotations may be on different slices within the same file. When you enter Edit mode, the displayed slice is updated to match the annotation orientation.

In Explore mode the annotation orientation cannot be updated; all annotations are read-only. You can still move the displayed slice, but that is not stored anywhere. Thus when you switch back to Edit mode, the displayed slice is updated to match the (unaltered) orientation of the annotation.


I think it would be more intuitive to change the default mode to Edit, and remove the default annotation. This way the more intuitive workflow would succeed, without needing to worry about a hidden, default, read-only state.

  • Open the program
    • (Scene is empty)
  • Add an annotation
    • (Implicitly enter edit mode)
  • Align the view
  • Place the annotation

Since it seems pretty common to forget to switch the mode before aligning; I expect it might also be common to forget to add an annotation before editing the view. New annotations are already oriented to match the displayed slice, so we would get the inverted workflow for free.

  • Open the program
    • (Scene is empty)
  • Align the view
  • Add an annotation
    • (Implicitly enter edit mode)
    • (Use the displayed orientation)
  • Place the annotation

To do this, I would suggest implementing these changes:

  • (1) If any annotation is selected in the sidebar, enter Edit mode for that annotation.
  • (2) When an annotation is added, select that annotation and enter Edit mode for it.
  • (3) When Explore mode is active, deselect annotations in the sidebar.
  • (4) Remove the default annotation from startup; the user must add the desired annotation and implicitly enter edit mode by (2)
@allemangD allemangD added Status: Triage Issues/PRs that need to be triaged Category: Usability It's working but inefficient and convulated labels Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Usability It's working but inefficient and convulated Status: Triage Issues/PRs that need to be triaged
Projects
None yet
Development

No branches or pull requests

1 participant