Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript SQL Data #36

Open
Sharabesh opened this issue May 21, 2016 · 2 comments
Open

Javascript SQL Data #36

Sharabesh opened this issue May 21, 2016 · 2 comments

Comments

@Sharabesh
Copy link
Collaborator

Sharabesh commented May 21, 2016

As we discussed, the SQL data was added to the variable "Test" in the Brainspell.php document using the Str_replace function. All of the code is within lines 1543 and 1610. The dictionaries in the variable can be used, but the location data itself is still nested as a string and needs to be parsed.

Here's my branch with I believe the most updated code
https://github.com/Sharabesh/brainspell/tree/Sharabesh_updated

Here's where I set the HTML Variable to an array containing the Database to be parsed in the Javascript
https://github.com/BIDS-collaborative/brainspell/compare/BIDS-collaborative...Sharabesh:Sharabesh_updated#diff-256f7777bc064f9f85c8ecb005d3c8abR1596

And here is the variable declaration in Search.html;

https://github.com/BIDS-collaborative/brainspell/compare/BIDS-collaborative...Sharabesh:Sharabesh_updated#diff-4bc774c1cdab1ae9d323d6c298e20ed6R93

@davclark
Copy link
Member

@Sharabesh you can always provide a link to the file in the repo. I think your code is here?

https://github.com/BIDS-collaborative/brainspell/blob/BIDS-collaborative/site/php/brainspell.php

You can provide a versioned link by clicking on the history button, then the <> button to view the file at a specific commit, here, I also clicked a line number to link to specific code (generally that's a bad idea for a link to master, as it can change):

function search_lucene($query)

That said, it would be great to get specific pointers... I'm not sure I see your code in the BIDS-collaborative repo. I think the variable is getting set here, for example?

https://github.com/Sharabesh/brainspell/blob/8cca20ef4923fc7950ada3e87c90f8f5d383282f/site/php/brainspell.php#L1596

Let us know where to look! You can also create a pull request in situations like this...

@Sharabesh
Copy link
Collaborator Author

I updated my original comment. Let me know if I should go ahead and add anything else. I'll go ahead and make a pull request as well just to be safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants