Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ADA / keyboard navigation features #13

Closed
4 tasks done
weotch opened this issue Oct 14, 2021 · 4 comments · Fixed by #62
Closed
4 tasks done

Implement ADA / keyboard navigation features #13

weotch opened this issue Oct 14, 2021 · 4 comments · Fixed by #62
Milestone

Comments

@weotch
Copy link
Member

weotch commented Oct 14, 2021

Notes:

@weotch weotch added this to the 2.0 - Non-MVP milestone Oct 14, 2021
@weotch weotch changed the title Implement AA ADA support Implement ADA / keyboard navigation features Oct 14, 2021
@sjstark
Copy link
Member

sjstark commented Jan 27, 2022

Should also pause autoplay features as mentioned in #28 (comment)

@weotch
Copy link
Member Author

weotch commented Mar 23, 2022

Running into an issue with the tabindex order since I'm using css order. I tried actually re-ordering the DOM elements during dragging to fix, but I saw some very weird behavior, like the contents of slides getting showing up in siblings. I think this would wreak havoc on slides that played videos too ...

I think I need to intercept the tab keypress, which feels gross ...

@weotch
Copy link
Member Author

weotch commented Mar 23, 2022

Ok, can I just disable looping when using the keyboard, that's the root of the issue.... can this be toggled at runtime ...

@weotch
Copy link
Member Author

weotch commented Mar 23, 2022

Yeah, I think disabling looping is gonna pan out for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants