Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Dashboard: Components #859

Merged
merged 12 commits into from
Feb 27, 2025

Conversation

proy30
Copy link
Member

@proy30 proy30 commented Feb 23, 2025

This PR refactors component logic for better maintainability, adds new components, and reorganizes file structures. Additionally, it makes the future migration to Vue 3 smoother.

  1. Split Component Logic

    • Moved code from Input/components.py into:
      • Input/components/card.py
      • Input/components/navigation.py
      • Input/components/input.py
  2. Create build_component Method

    • Introduced a helper method to encapsulate common vuetify properties (e.g., label, v_model, dense, v_on, v_bind) across components, reducing duplication. Changes can be made in one central location if we need to apply a consistent style or update properties when switching Vue versions.
  3. Add Vuetify Components

    • Integrated Vuetify's button, checkbox, and combobox components which utilize build_component.

Cleanup

  • Moved multi-grid settings code to a helper file.
  • Removed the unused expand_configuration method.

@proy30 proy30 added the component: dashboard our browser based trame dashboard label Feb 23, 2025
@proy30 proy30 force-pushed the dashboard/refactor_components branch from 9b49650 to 2c1e42a Compare February 25, 2025 19:44
@proy30 proy30 force-pushed the dashboard/refactor_components branch from a279d17 to 1237fce Compare February 25, 2025 22:11
@proy30 proy30 changed the title [Draft] Refactor Dashboard: Components [WIP] Refactor Dashboard: Components Feb 26, 2025
@proy30 proy30 force-pushed the dashboard/refactor_components branch from 9716229 to ae14464 Compare February 27, 2025 02:57
@proy30 proy30 changed the title [WIP] Refactor Dashboard: Components Refactor Dashboard: Components Feb 27, 2025
@proy30 proy30 requested review from ax3l, cemitch99 and EZoni February 27, 2025 03:19
@ax3l ax3l merged commit afb3437 into BLAST-ImpactX:development Feb 27, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard our browser based trame dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants