Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate text-based hotfix specification in edit window #55

Open
apocalyptech opened this issue Aug 20, 2023 · 0 comments
Open

Alternate text-based hotfix specification in edit window #55

apocalyptech opened this issue Aug 20, 2023 · 0 comments
Labels
enhancement New feature or request needs investigation Still need to nail down exactly what the issue is

Comments

@apocalyptech
Copy link
Contributor

apocalyptech commented Aug 20, 2023

I've always found BLCMM's hotfix handling cumbersome. Multiple dropdowns, not being able to edit dissimilar hotfix types at the same time, etc... I'd like to support an alternate form of hotfix editing which users could use instead, essentially based on mystise's old Hotfix Converter (which I believe predates even FilterTool).

Specifically, hotfixes could be specified like:

level None set foo bar baz
level Level_P set foo bar baz
demand GD_Siren_Streaming set foo bar baz

set_cmp could be used internally there as usual. This syntax would be a little more verbose than the Hotfix Converter syntax, since it wouldn't support "blocks" of hotfixes like that one. It would be pretty easy to just copy+paste stuff if doing a big block, though, and you could trivially edit all sorts of disparate hotfixes all at the same time.

We'd want to make sure that autocomplete handling could provide level + on-demand names; one downside to this is that "English" level names might be more difficult to convey, since they'd end up just showing their *_P format.

We'd need to make sure the "can we edit code" check is updated so that the user can select disparate hotfixes for the Edit action, if this mode is enabled. We may want to provide a checkbox right in the Edit window itself, too? Though to support that, we'd also need to parse the current code to find mismatched hotfixes, which might be more than we want to do with live-updated text. So maybe it's best kept as something in the settings menu.

@apocalyptech apocalyptech added enhancement New feature or request needs investigation Still need to nail down exactly what the issue is labels Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs investigation Still need to nail down exactly what the issue is
Projects
None yet
Development

No branches or pull requests

1 participant