-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File dialog opening can cause a crash, at least on Windows #72
Labels
bug
Something isn't working
Comments
From the reporting user, btw, here's what was done on the PC which seems to have resulted in this file-dialog behavior:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
System Info
Operating System:
Windows (unsure of exact version)
Describe the bug
Opening a file dialog, under some circumstances (such as
File -> Open
) can lead to a crash with a relatively-unhelpful traceback like so:It seems likely to somehow have something to do with network accessibility. Also in the user's logfile above was this line:
Some random searching around has yielded a couple of hits for this, both seemingly relating to network permissions, though both are pretty old. Here's a JDK bug from way back in the early 2000s talking about a Windows NT machine: https://bugs.openjdk.org/browse/JDK-4879395 -- And here's a StackOverflow post: https://stackoverflow.com/questions/17644390/what-causes-an-internalerror-to-be-thrown-by-sun-awt-shell-win32shellfolder2-ini (note the "Edit 2" specifically, which calls out a
Win32ShellFolder2.NETWORK
argument).Also from the reporting user (in Discord):
So it does seem awfully likely that
JFileChooser
must have some problems when certain network attempts are made, which can result in a crash. It's rather vexing because I do intend OpenBLCMM to be fully functional without any network. The only intended network call is to check for a new version, which should fail gracefully (and can be toggled off by the user).This happened for the user both on the EXE version (still Liberica NIK's Java 17), and on Pure Java on (I believe) Java 8.
So anyway, I'll have to see if I can reproduce this in a VM and then see what can be done about it. If I can't fix JFileChooser (which, honestly, seems like a pretty likely case), perhaps I could at least fall back to a more basic file-chooser dialog instead? The SO post mentions trying
FileDialog
instead... We'll have to see.The text was updated successfully, but these errors were encountered: