Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion - Setting for custom output elements #13

Open
AforDesign opened this issue Dec 2, 2022 · 2 comments
Open

Suggestion - Setting for custom output elements #13

AforDesign opened this issue Dec 2, 2022 · 2 comments

Comments

@AforDesign
Copy link

First of all, thank you for this awesome class.

I have a request / suggestion for a future enhancement:
It would be nice to be able to overrule the html output via the settings.

For example:
I stumbled upon a performance issue when dealing with a list of 1500 items including image previews.
Allthough the image are only a few kb, i t's quite a performance hit.
Therefor I needed to lazy-load them.
To be able to do that I had to modify the source code.

 // Check for Attachment
 if (optionImg) {
    var has_attachment = "<img data-src=" + optionImg + " class='lazyload'>";
} 

No big deal ofcourse, but it would be super nice if such alteration could be added to the settings object.

@BMSVieira
Copy link
Owner

Hey there!

It is actually a really good sugestion, it might take a while since im running short on time, but i will do that.
Be welcome to open a PR!

Have a nice day!

@AforDesign
Copy link
Author

Thanks in advance!
Great to here you like such a feature.

Like you, I'm short on time too.
If I'm more or less back on schedule I can look into opening a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants