New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UART interface #7

Open

tvannoy opened this issue Oct 30, 2024 · 0 comments

Labels

Member

tvannoy commented Oct 30, 2024

The user experience and interface for sending DAC voltages via UART is pretty bad:

Very little feedback is provided
If the user enters more characters than the buffer's length, the beginning of the buffer gets overwritten

Rather than using a circular buffer and overwriting previous characters, maybe we should

make the buffer larger than needed
ignore any input that goes beyond the buffer size
wait until the user enters a carriage return before setting the buffer index back to 0; i.e., don't set the index back to 0 when we reach the end of the buffer without a carriage return.

tvannoy added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment