Remove two unnecessary null pointer checks for the variable “m_RPCWaitDlg”

[elfring]

👀 The member function “CMainDocument::RequestRPC” contains the statement “m_RPCWaitDlg = new AsyncRPCDlg();”.
Redundant checks are still applied (despite of this implementation detail).
💭 Thus I suggest to remove them.

[AenBleidd]

You can go ahead and create a PR with the fix 😉

[elfring]

🔮 The software evolution can be continued accordingly, can't it?

[davidpanderson]

If we're going to clean up the logic here let's finish the job,
and create the dialog only if it's actually used.

[elfring]

…, and create the dialog only if it's actually used.

Will further source code adjustments belong to other issues? 🤔

[AenBleidd]

@elfring, this particular request belongs to the same PR: #5379.

[elfring]

@davidpanderson did not add his comment as a direct contribution to my pull request for this issue.

[AenBleidd]

@elfring, ok, if you want, I can say next way: request of @davidpanderson belongs to this particular issue (#5378) and the corresponding PR (#5379)

[elfring]

💭 I would prefer a clearer separation between remaining open issues for the affected software components.

[AenBleidd]

@elfring, you're the author of this issue. It was a request from the maintainer to improve your PR. This improvement belongs to the same component and to the same function that is touched by your PR.
Please, take into the consideration the comment from the maintainer and improve your PR.
Thank you in advance

[AenBleidd]

Closing this as 'not needed'. Please read more detailed explanation here: #5379 (comment)