Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[style] Include guard project prefix BITCOIN_ -> BTCP_ #61

Open
ch4ot1c opened this issue Aug 2, 2018 · 1 comment
Open

[style] Include guard project prefix BITCOIN_ -> BTCP_ #61

ch4ot1c opened this issue Aug 2, 2018 · 1 comment
Labels
Backlog Brainstorming enhancement New feature or request

Comments

@ch4ot1c
Copy link
Contributor

ch4ot1c commented Aug 2, 2018 •
edited by BlueSilver22
Loading

https://github.com/bitcoin/bitcoin/blob/master/test/lint/lint-include-guards.sh#L19

The linter requires project prefix BITCOIN_, and then a path from src/ separated by underscores. We could make this BTCP eventually.

More generally, this is a call for conscious directory-naming practices. No changes are required; non-urgent, may have unintended consequences.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@ch4ot1c ch4ot1c added enhancement New feature or request Brainstorming labels Aug 2, 2018
@ch4ot1c
Copy link
Contributor Author

ch4ot1c commented Oct 2, 2018

Is this backlogged, or closed as won't do?

@ch4ot1c ch4ot1c added the Backlog label Oct 2, 2018
@ch4ot1c ch4ot1c reopened this Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Backlog Brainstorming enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ch4ot1c @BlueSilver22