New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetSerializeSize for dbwrapper #68

Open

ch4ot1c opened this issue Oct 2, 2018 · 0 comments

Contributor

ch4ot1c commented Oct 2, 2018 •

edited by BlueSilver22

Loading

In dbwrapper.h:

        CDataStream ssKey(SER_DISK, CLIENT_VERSION);
        ssKey.reserve(DBWRAPPER_PREALLOC_KEY_SIZE);
        ssKey << key;
        leveldb::Slice slKey(ssKey.data(), ssKey.size());

This is the newer Bitcoin idiom.

However, when cherrypicking from Zcash commit a8e5ae9:

Is preallocated size preferred, or is there an important reason to GetSerializeSize here?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment