New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: Improve astro dist local hosting #50

Closed

grctest opened this issue Mar 1, 2025 · 1 comment

Contributor

grctest commented Mar 1, 2025

Currently we host the astro dist files via express then navigate to that from within the client.

There's some problems with this:

You can navigate to the astro page from your desktop if you know the port, however since the main thread is communicated to via the electron context isolation method this web browser view largely doesn't work.
You can't open a second instance of the application, as the port is already in use.

Solutions:

Host files within electron more natively, as opposed to using express.
Introduce additional port switching logic for second instances of the app launching

Contributor Author

grctest commented Mar 23, 2025

Resolved by the latest version! No longer using express!

grctest closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment