-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes in allele calling module #21
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
saramonzon
commented
Apr 19, 2024
•
edited
Loading
edited
- Added evaluation identity as parameter for reference alleles
- Variable and function renaming as refactor for allele_calling module
- changed exact match detection from grep to biopython
- Fix when allele was LNF was classified as locus_name instead of LNF
- Changed allele_details format from list to dictionary for easier reading and use.
- ASM and ALM evaluation is when sample allele seq is greater or lesser than the reference allele length +/- 20% of its length
- Refactor protein fixed when sample allele seq can't be translated:
- Now is executed after checking for exact match
- Now checks for both forward and reverse senses, as well as, contig strand.
- Tries to extend in case of not stop codon, not start codon and not multiple of three.
- Now it directly uses biopython translate errors.
…nd classification match
…s passed to inferred alleles
…restructuring in next commit
…xtend to find start/stop codon only after exact match testing, some comment cleaning
…ter protein fixing
…t multiple of three
luissian
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.