Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in allele calling module #21

Merged
merged 19 commits into from
Apr 19, 2024
Merged

Conversation

saramonzon
Copy link
Member

@saramonzon saramonzon commented Apr 19, 2024

  • Added evaluation identity as parameter for reference alleles
  • Variable and function renaming as refactor for allele_calling module
  • changed exact match detection from grep to biopython
  • Fix when allele was LNF was classified as locus_name instead of LNF
  • Changed allele_details format from list to dictionary for easier reading and use.
  • ASM and ALM evaluation is when sample allele seq is greater or lesser than the reference allele length +/- 20% of its length
  • Refactor protein fixed when sample allele seq can't be translated:
    • Now is executed after checking for exact match
    • Now checks for both forward and reverse senses, as well as, contig strand.
    • Tries to extend in case of not stop codon, not start codon and not multiple of three.
    • Now it directly uses biopython translate errors.

@saramonzon saramonzon requested a review from luissian April 19, 2024 15:59
@luissian luissian merged commit 68a5f3c into BU-ISCIII:develop Apr 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants