Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextFile model fails silently with incompatible calibration data #16

Open
IvanHeriver opened this issue Oct 15, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@IvanHeriver
Copy link
Collaborator

Description

For certain formula, certain input values are not permitted. For example in the equation h^c where h is the input variable, if the calibration data contains a negative input value (and c is not an integer) the equation is no longer valid. However, BaM produces results when I think it should fail with an explicit error message. Instead Results_MCMC_Cooked.txt contains the same value repeated for each row and LogPost values are set to NaN.

This is not so problematic since the results are clearly not valid but I'd prefere BaM to crash.

Reproduction

In the attached file, you can test this by modifying the calibration data (file Data_fakeCalibrationData.txt) from the not working case

X_h Y_Q
-1.0 0.0

to this working case

X_h Y_Q
1.0 0.0

Not that for this example to work, you need to launch BaM from within the directory where all the config files are since relative paths are broken otherwise (I might open another issue for this). From within the config files directory, run /path/to/BaM/exe -cf "./Config_BaM.txt

ISSUE_INVALID_CALIBRATION_DATA.zip

@IvanHeriver IvanHeriver added the bug Something isn't working label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant