Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Contributing Guidelines #610

Open
m-sameer opened this issue Oct 10, 2018 · 8 comments
Open

Enhance Contributing Guidelines #610

m-sameer opened this issue Oct 10, 2018 · 8 comments

Comments

@m-sameer
Copy link
Collaborator

In my opinion, there should be a code boilerplate or a linter which should check the code and only those PRs which pass the Linter would be allowed to merge.

Feel free to give your personal opinion

@m-sameer
Copy link
Collaborator Author

@TomerPacific Wanna take this?

@TomerPacific
Copy link
Contributor

@m-sameer,
sure, but I will need some pointers in regards to what linter or service you guys would like to use and how to implement it. Never have done this kind of thing before.

@m-sameer
Copy link
Collaborator Author

Maybe add a test to run this on TravisCI for every code file.

@TomerPacific
Copy link
Contributor

@m-sameer ,
never worked with TravisCI before. Do I need to add anylint as a dependency to the project via package.json? Any pointers to how to get started with this task will help.

@m-sameer
Copy link
Collaborator Author

If I knew anything about this, I would have done this issue myself. I would have to first research, and this is something you can do yourself.
And yeah, you have to add AnyLint as a dependency of this repo.

@m-sameer
Copy link
Collaborator Author

What about this?

@TomerPacific
Copy link
Contributor

@m-sameer ,
sorry I am replying late, but I have been busy. Consider assigning this to someone else as I will not have time for this in the foreseeable future.

@m-sameer
Copy link
Collaborator Author

m-sameer commented Nov 17, 2018

@TomerPacific It's okay, brother. Talking about assigning it to someone else, no one takes a look at this repo until it's October, so that's useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants