Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move component option to top-level #8

Open
Atinux opened this issue Jul 15, 2022 · 1 comment
Open

Move component option to top-level #8

Atinux opened this issue Jul 15, 2022 · 1 comment

Comments

@Atinux
Copy link

Atinux commented Jul 15, 2022

It should be a top-level option:

newsletter: {
  component: true,
  // mailchimp | revue | buttondown
  <YOUR_NEWSLETTER_PROVIDER>: {
    // options like apiKey
  }
}

Also, you could support the provider prop in the component to use one of the providers defined (default to the first one defined).

@Baroshem
Copy link
Owner

Hey @Atinux

Thanks for the recomendation.

The component option as the top level seems like a very good idea!

In terms of provider in components, I dont think it is possible as the provider is used to define the server middleware that should be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants