Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove injection of BartaMathLibrary #11

Closed
Bartanakin opened this issue Oct 30, 2024 · 0 comments · Fixed by #32
Closed

Remove injection of BartaMathLibrary #11

Bartanakin opened this issue Oct 30, 2024 · 0 comments · Fixed by #32
Assignees
@tkz789
Labels
Easy Scale of knowledge of the project requirement Quick Scale of workload requirement

Comments

@Bartanakin
Copy link
Owner

Bartanakin commented Oct 30, 2024 •
edited
Loading

It is relevant to inject BartaMathLibrary both into StaticCollisionDetectionStrategy and DynamicCollisionDetectionStrategy.

You should move it to the Utilities directory and split the class into functions. Add a subnamespace (fe. Barta::Utils) and replace all the occurrences of the methods.

The Barta::MathLibraryInterface is to be deleted too.
@Bartanakin Bartanakin added Easy Scale of knowledge of the project requirement Quick Scale of workload requirement labels Oct 30, 2024
@tkz789 tkz789 self-assigned this Nov 10, 2024
@tkz789 tkz789 linked a pull request Nov 10, 2024 that will close this issue
Removed MathLibraryInterface #32
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkz789 tkz789

Labels
Easy Scale of knowledge of the project requirement Quick Scale of workload requirement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed MathLibraryInterface Bartanakin/BartaEngine
2 participants
@Bartanakin @tkz789