Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows compatability #1

Open
staal opened this issue Jan 15, 2016 · 1 comment
Open

Windows compatability #1

staal opened this issue Jan 15, 2016 · 1 comment

Comments

@staal
Copy link

staal commented Jan 15, 2016

Hi there,

I stumbled upon your repo searching for doxygen usage in cmake. I like the idea behind it but it's not really well structured for Windows, Visual Studio specifically. I would really remove "SHARED" from build targets, using the standard way to build shared by setting the flag BUILD_SHARED_LIBS in your cmake cache. See https://cmake.org/cmake/help/v3.0/variable/BUILD_SHARED_LIBS.html#variable:BUILD_SHARED_LIBS

Windows shared(DLL) creation is slightly more involved, again see https://cmake.org/Wiki/BuildingWinDLL

In your Doxygen.in files you should modify DOT_PATH to be:

DOT_PATH = @DOXYGEN_DOT_EXECUTABLE@

That way you don't need Graphviz on PATH, but can define it yourself.

I could make a PR with the above mentioned changes, plus cleaning up some deprecated cmake ways since 3.0 if you'd accept it.

@Barthelemy
Copy link
Owner

Hi,

Sorry for the late reply, I was away for a few days.

Thank you for your comments. I have not tested the project on windows. I would be grateful if you could make a PR and I would then test it on Linux and Mac (and Windows).

Concerning the clean up of deprecated CMake, the project is compatible with CMake > 2.8. Would your changes force users to use CMake > 3 ?

Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants