Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website Dark Mode switch #30

Open
zen0bit opened this issue Feb 23, 2024 · 11 comments
Open

website Dark Mode switch #30

zen0bit opened this issue Feb 23, 2024 · 11 comments

Comments

@zen0bit
Copy link
Contributor

zen0bit commented Feb 23, 2024

I see that we use bootswatch theme version 4.

Why not use version 5 which introduced light/dark theme switch instead?

It coulde solved it..

PS: Not sure if something must be changed in raito..

@vaisarger
Copy link
Member

Hi @zen0bit , same no notification of new issue here... mmh... I'm little disappointed of Github!
Anyway... Well, if you would like to solve it, you're welcome!
Unfortunately, I'm not good in these issues... and I'm pretty useless here... :(

Let me know how to proceed... :)

@mckaygerhard
Copy link
Contributor

@zen0bit if you solve it using BW5 just test it and report feedback i am also interested, can you post a PR with allow to squash the commits? note that you must allow squash and edit from collaborators in the PR ..

@mckaygerhard
Copy link
Contributor

for discussion if there are so much to disscuss go to #32

@bmullan
Copy link

bmullan commented Jun 27, 2024

I think the color scheme for this section of EasyBash GUI website is an awful choice.

Some info, like the table of functions is hardly readable.

Is that related to this thread discussion?

Why not use version 5 which introduced light/dark theme switch instead?

@vaisarger
Copy link
Member

vaisarger commented Jun 27, 2024 via email

@mckaygerhard
Copy link
Contributor

mckaygerhard commented Jun 27, 2024

@bmullan the new web siute was improved usiing EBG mardkdown files..but is not deployed anymore @vaisarger becouse all sites now build and deploy with GitHub Actions (previously was a very simple process, just an option on the settings project).

i opened an issue about it: #39

HINT: Fortunatelly we do not need a "step of build for pages" our EBG web is totally rendered dinamically on each request.. means thanks ot the power of Raito see it https://raito.arnaud.at/#/ @bmullan :

  • Copy index.html to your website root
  • Write your homepage in README.md
  • Every MarkDown file will turn into a page ✨ (no builds need, direct deploy)

@vaisarger
Copy link
Member

vaisarger commented Jun 27, 2024

By the way, I tried to improve the old original EBG site with a more readable theme:
https://sites.google.com/site/easybashgui/easy-bash-functions

Maybe colors are not so spectacular, but now it should be more readable!

Thank you all for your contribution... :)

@mckaygerhard
Copy link
Contributor

By the way, I tried to improve the old original EBG site with a more readable theme: https://sites.google.com/site/easybashgui/easy-bash-functions

you must update the redirection link from http to https.. to avoid the halted state

@bmullan
Copy link

bmullan commented Jun 27, 2024

At least its readable but it still has a strange look to it because of the colors used.

@bmullan
Copy link

bmullan commented Jun 27, 2024

The new Pink background with Black Text looks good but only for the Black Text that is in Bold.

The non-Bold Text is still hard to see & read (just my opinion).

What do you think...?

easybashgui-pic

A Yellow background with Black text might provide more Contrast for all the text.

@vaisarger
Copy link
Member

vaisarger commented Jun 27, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants