Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make advancements configurable. #74

Open
XEpicLi opened this issue Oct 5, 2024 · 4 comments
Open

Make advancements configurable. #74

XEpicLi opened this issue Oct 5, 2024 · 4 comments

Comments

@XEpicLi
Copy link

XEpicLi commented Oct 5, 2024

When you disable some vanilla materials but not used in trim in vanilla minecraft(like coal), these advancements are still there(unachievable). Maybe these advancements can be disabled automatically(if players do not have all the trim mod)? Or will there be a master control for advancements?

@XEpicLi
Copy link
Author

XEpicLi commented Oct 5, 2024

Or maybe we can split this mod into vanilla, vanilla-like and all-the-trim version? I think these would be nice for players who don't want to override minecraft too much.

@Bawnorton
Copy link
Owner

Bawnorton commented Oct 5, 2024

Maybe these advancements can be disabled automatically

Likely what I will do

split this mod into vanilla, vanilla-like and all-the-trim version

Not gonna happen, I already maintain enough projects + a job + uni

@XEpicLi
Copy link
Author

XEpicLi commented Oct 5, 2024

Will deleting advancements json files in mod/data/bettertrims/advancements be safe? Like disabling advancements manually.

@Bawnorton
Copy link
Owner

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants