From dd6a24042110b1f5e0fcae2d9f748e3d621817a4 Mon Sep 17 00:00:00 2001 From: fishphobiagg Date: Wed, 27 Sep 2023 00:03:23 +0900 Subject: [PATCH] =?UTF-8?q?fix:=20=EB=9E=AD=ED=82=B9=20=EB=8D=B0=EC=9D=B4?= =?UTF-8?q?=ED=84=B0=20=EB=AF=B8=EC=A1=B4=EC=9E=AC=EC=8B=9C=20TOP=20?= =?UTF-8?q?=EA=B2=8C=EC=8B=9C=EB=AC=BC=20null=20=EA=B0=92=20=EB=B0=98?= =?UTF-8?q?=ED=99=98=20=EB=B0=8F=20=EA=B7=B8=EB=A6=BC=20=EB=B3=80=ED=99=98?= =?UTF-8?q?=ED=95=98=EA=B8=B0=20=EC=9D=91=EB=8B=B5=EA=B0=92=20=EC=88=98?= =?UTF-8?q?=EC=A0=95=20[BACK-252]=20Resolves=20:=20issue=20#253?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../domain/canvas/service/CanvasUpdateService.java | 4 ++-- .../siliconvalley/domain/post/service/RankCachingService.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/siliconvalley/domain/canvas/service/CanvasUpdateService.java b/src/main/java/com/siliconvalley/domain/canvas/service/CanvasUpdateService.java index da4d0cb..8b03074 100644 --- a/src/main/java/com/siliconvalley/domain/canvas/service/CanvasUpdateService.java +++ b/src/main/java/com/siliconvalley/domain/canvas/service/CanvasUpdateService.java @@ -1,6 +1,7 @@ package com.siliconvalley.domain.canvas.service; import com.siliconvalley.domain.canvas.domain.Canvas; +import com.siliconvalley.domain.canvas.dto.CanvasConvertResponse; import com.siliconvalley.domain.image.service.S3ImageUploadService; import com.siliconvalley.domain.post.service.RankCachingService; import com.siliconvalley.domain.rabbitMQ.code.RabbitMQCode; @@ -27,7 +28,6 @@ public Response updateSketchAndCanvas(Canvas canvas, String newSketch, Long prof s3ImageUploadService.deleteImage(canvas.getSketch()); canvas.updateSketch(newSketch); convertRequestSender.sendSketchConversionRequest(newSketch, canvas.getId(), profileId, canvas.getSubject()); - return Response.of(RabbitMQCode.CONVERSION_RESPONSE_SUCCESS, rankCachingService.getTopPostThisWeek(canvas.getSubject().getId())); + return Response.of(RabbitMQCode.CONVERSION_RESPONSE_SUCCESS, new CanvasConvertResponse(canvas.getId(), rankCachingService.getTopPostThisWeek(canvas.getSubject().getId()))); } - } diff --git a/src/main/java/com/siliconvalley/domain/post/service/RankCachingService.java b/src/main/java/com/siliconvalley/domain/post/service/RankCachingService.java index 6f0b8b1..c65349b 100644 --- a/src/main/java/com/siliconvalley/domain/post/service/RankCachingService.java +++ b/src/main/java/com/siliconvalley/domain/post/service/RankCachingService.java @@ -38,7 +38,7 @@ public void cachingRankToRedis(RankingCachingDto rankingCachingDto){ public String getTopPostThisWeek(Long subjectId){ RankingCachingDto rankingCachingDto = redisTemplate.opsForList().index(generateRedisKey(subjectId), -1); if (rankingCachingDto.getRankerList().isEmpty()){ - return "ranking is empty"; + return null; } return rankingCachingDto.getRankerList().get(0).getCanvasUrl(); }